After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734775 - androidmedia: Should not send EOS when drained
androidmedia: Should not send EOS when drained
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-14 10:21 UTC by Sebastian Dröge (slomo)
Modified: 2014-08-14 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2014-08-14 10:21:43 UTC 
+++ This bug was initially created as a clone of Bug #734617 +++

This is for the audio decoder and video decoder and video encoder. Currently we forward an EOS event from our srcpad task whenever GstVideo*::finish() is called or GstAudio*::handle_frame(NULL). This is however used for draining.

We should only drain, and then let the EOS event be handled from the streaming thread of the sinkpad (which is no problem as the srcpad streaming thread is not doing anything anymore after draining).
Comment 1 Sebastian Dröge (slomo) 2014-08-14 12:27:48 UTC 
commit 8f25220b9c0426c38122419060cbbc63ab1a74d2
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Aug 14 15:26:53 2014 +0300

    androidmedia: Make sure to unblock any thread waiting on the drain condition variable when errors happen

commit ca62186797271ebda3966fd9f0de3b961c83c50e
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Aug 14 15:24:21 2014 +0300

    androidmedia: Fix draining logic to let the base class handle EOS events
    
    https://bugzilla.gnome.org//show_bug.cgi?id=734775