After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734753 - Path bar - buttons don't have enough padding
Path bar - buttons don't have enough padding
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
3.14
Depends on:
Blocks:
 
 
Reported: 2014-08-14 00:03 UTC by Allan Day
Modified: 2014-08-29 03:10 UTC
See Also:
GNOME target: 3.14
GNOME version: ---

Attachments
before and after screenshot (35.39 KB, image/png)
2014-08-14 00:03 UTC, Allan Day 		  Details
Adwaita: pathbar whitespace (2.05 KB, patch)
2014-08-29 00:43 UTC, Jakub Steiner 		committed Details | Review
screenshot of the suggested change of spacing (118.37 KB, image/png)
2014-08-29 00:44 UTC, Jakub Steiner 		  Details

Description Allan Day 2014-08-14 00:03:04 UTC 
Created attachment 283333 [details]
before and after screenshot

This is something that came in with the Adwaita rewrite - pathbar buttons don't have enough padding. Everything is very tight, and text and icons in the buttons aren't vertically centered.

The following CSS in the inspector seems to fix things for me:

.text-button { padding: 6px 12px 6px 12px; }

I've attached a before and after screenshot.
Comment 1 Lapo Calamandrei 2014-08-15 14:06:29 UTC 
The 'lack' of padding is to have more buttons fit in the pathbar which is particularly relevant in nautilus side by side usage
Comment 2 Lapo Calamandrei 2014-08-15 14:12:50 UTC 
See https://bugzilla.gnome.org/show_bug.cgi?id=733313
Comment 3 Allan Day 2014-08-15 15:17:33 UTC 
(In reply to comment #1)
> The 'lack' of padding is to have more buttons fit in the pathbar which is
> particularly relevant in nautilus side by side usage

Could we meet half-way? It doesn't look great to me, currently.

Also, what do you think of the vertical alignment issues? They're bugging me...
Comment 4 Jakub Steiner 2014-08-29 00:07:58 UTC 
We can go the buttonless pathbar in the future, but for now I'm definitely leaning towards having some horizontal whitespace. Looks really unbalanced as is.
Comment 5 Jakub Steiner 2014-08-29 00:43:29 UTC 
Created attachment 284765 [details] [review]
Adwaita: pathbar whitespace

- optically center icons + labels vertically. It isn't actually
  centered, but feels more balanced
- add some left/right padding
Comment 6 Jakub Steiner 2014-08-29 00:44:54 UTC 
Created attachment 284766 [details]
screenshot of the suggested change of spacing
Comment 7 Matthias Clasen 2014-08-29 03:10:40 UTC 
Attachment 284765 [details] pushed as c5d4485 - Adwaita: pathbar whitespace