After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734734 - Print multiple sudokus dialog should be set transient for the main window
Print multiple sudokus dialog should be set transient for the main window
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-13 19:40 UTC by Michael Catanzaro
Modified: 2014-08-29 21:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Using the ui file for the radiogroup. (3.23 KB, patch)
2014-08-23 03:56 UTC, Arnaud B. 		committed Details | Review
Don't use Gtk.VBox. (1.84 KB, patch)
2014-08-23 03:57 UTC, Arnaud B. 		committed Details | Review
Don't show the dialog before it is made transient. (760 bytes, patch)
2014-08-23 03:58 UTC, Arnaud B. 		committed Details | Review

Description Michael Catanzaro 2014-08-13 19:40:22 UTC 
The print multiple sudokus dialog needs to be set transient for the main window. It looks like there's already code to handle this, so I guess some debugging will be required to figure out why that's broken.
Comment 1 Arnaud B. 2014-08-23 03:56:15 UTC 
Created attachment 284272 [details] [review]
Using the ui file for the radiogroup.

It’s just that the dialog is shown at his creation, as requested the ui file. Here are three patches, the two first are little things I corrected why understanding the problem, the third is the one-line-patch-solution. ^^
Comment 2 Arnaud B. 2014-08-23 03:57:09 UTC 
Created attachment 284273 [details] [review]
Don't use Gtk.VBox.

Deprecated…
Comment 3 Arnaud B. 2014-08-23 03:58:00 UTC 
Created attachment 284274 [details] [review]
Don't show the dialog before it is made transient.

Yay!
Comment 4 Parin Porecha 2014-08-29 21:08:14 UTC 
Comment on attachment 284272 [details] [review]
Using the ui file for the radiogroup.

Pushed as 6c04060
Comment 5 Parin Porecha 2014-08-29 21:08:40 UTC 
Comment on attachment 284273 [details] [review]
Don't use Gtk.VBox.

Pushed as 111d6f9
Comment 6 Parin Porecha 2014-08-29 21:08:56 UTC 
Comment on attachment 284274 [details] [review]
Don't show the dialog before it is made transient.

Pushed as 20f0558