After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734724 - Maybe highlighter should be optional
Maybe highlighter should be optional
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-13 15:50 UTC by Michael Catanzaro
Modified: 2014-11-10 21:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot showing higlighter and fixed cell colors (23.75 KB, image/png)
2014-08-13 16:04 UTC, Parin Porecha 		  Details
My proposed patch to implement this. (5.53 KB, patch)
2014-11-10 20:41 UTC, Andrei Ghincu 		committed Details | Review

Description Michael Catanzaro 2014-08-13 15:50:14 UTC 
I really like the highlighter feature when playing with the keyboard, but when playing with the mouse (which I guess most users will do) I think it just gets in the way. I'm starting to think this should be a preference after all, and default to off.
Comment 1 Parin Porecha 2014-08-13 16:04:47 UTC 
Created attachment 283311 [details]
Screenshot showing higlighter and fixed cell colors

Okay.

and talking about the highlighter, we also need to finalize the colors.
Allan, right now we use a light shade of gray to highlight cells, and dark gray background for fixed cells (screenshot attached).
Do these colors need tweaking ?
Comment 2 Andrei Ghincu 2014-11-10 20:41:06 UTC 
Created attachment 290378 [details] [review]
My proposed patch to implement this.
Comment 3 Michael Catanzaro 2014-11-10 21:34:58 UTC 
Review of attachment 290378 [details] [review]:

Looks good, thanks!

::: data/gnome-sudoku-menu.ui
@@ +26,3 @@
       <section>
         <item>
+          <attribute name="label" translatable="yes">_Highlighter</attribute>

These underscores aren't actually used for accelerators as far as I can tell, but if they were you wouldn't want two on the same letter (it clashes with Help). So I'm going to move this to a different letter before I push.