After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734666 - audiodecoder: Don't drain and flush on SEGMENT events.
audiodecoder: Don't drain and flush on SEGMENT events.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-12 13:22 UTC by Jan Schmidt
Modified: 2014-08-12 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audiodecoder: Don't drain and flush on SEGMENT events. (2.39 KB, patch)
2014-08-12 13:39 UTC, Jan Schmidt 		accepted-commit_now Details | Review

Description Jan Schmidt 2014-08-12 13:22:52 UTC 
As was done for the base video decoder in commit 695675, don't flush out the decoder on a new SEGMENT event. Segment events may be a new segment, but are also often segment updates for the current segment where the old data should be kept. For new segments, a STREAM_START event will already trigger a drain, but make sure to flush any remaining partial data then as well.
Comment 1 Jan Schmidt 2014-08-12 13:39:08 UTC 
Created attachment 283199 [details] [review]
audiodecoder: Don't drain and flush on SEGMENT events.

As was done for the base video decoder in commit 695675, don't
flush out the decoder on a new SEGMENT event. Segment events
may be a new segment, but are also often segment updates for
the current segment where the old data should be kept. For new
segments, a STREAM_START event will already trigger a drain, but
make sure to flush any remaining partial data then as well.