GNOME Bugzilla – Bug 734650
videoscale: Does not support NV21 format
Last modified: 2014-08-12 11:33:06 UTC
Created attachment 283168 [details] [review] videoscale: Patch to support NV21 format Videoscale plugin does not support NV21 format. Added support for this by reusing the code of NV12 as NV21 just u, v are reversed and exactly same logic could be reused. Tested it with below pipeline and its working well gst-launch-1.0 videotestsrc num-buffers=100 ! "video/x-raw, width=780" ! videoscale ! "video/x-raw, format={NV21}, width=1233" ! videoconvert ! autovideosink
Review of attachment 283168 [details] [review]: ::: gst/videoscale/gstvideoscale.c @@ +75,1 @@ #include <math.h> Why do you include stdio.h? Was it missing for something before? @@ +1143,1 @@ interlaced = GST_VIDEO_FRAME_IS_INTERLACED (in_frame); Whitespace change that is unneeded :) Please remove if you update the patch for the #include
Created attachment 283174 [details] [review] videoscale: Added support for NV21 Sorry, had added stdio.h for debugging purpose. Not required for patch. Have removed it. Resubmitting the patch
Note that you can also use g_print() instead of printf(). It requires no stdio.h and works the same. commit 8cab1ab5fca0e0084141525f89a8d703ea8dc285 Author: Sanjay NM <sanjay.nm@samsung.com> Date: Mon Aug 11 10:15:14 2014 +0530 videoscale: Add NV21 support https://bugzilla.gnome.org/show_bug.cgi?id=734650