After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734555 - Add location settings
Add location settings
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 734483
 
 
Reported: 2014-08-09 14:57 UTC by Zeeshan Ali
Modified: 2014-08-10 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add location settings (2.78 KB, patch)
2014-08-09 14:57 UTC, Zeeshan Ali 		needs-work Details | Review
Add location settings (3.12 KB, patch)
2014-08-09 15:51 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2014-08-09 14:57:34 UTC 
See patch.

We'll need this for bug#734483.
Comment 1 Zeeshan Ali 2014-08-09 14:57:36 UTC 
Created attachment 283008 [details] [review]
Add location settings

Moving location settings from gnome-shell to here because they will now
also be accessed by gnome-control-center.
Comment 2 Bastien Nocera 2014-08-09 15:22:05 UTC 
Review of attachment 283008 [details] [review]:

::: schemas/org.gnome.system.location.gschema.xml.in.in
@@ +1,2 @@
+<schemalist gettext-domain="gsettings-desktop-schemas">
+  <enum id="org.gnome.system.location.AccuracyLevel">

Nope. You add them to gdesktop-enums.h

@@ +10,3 @@
+  <schema id="org.gnome.system.location"
+          path="/org/gnome/system/location/"
+          gettext-domain="@GETTEXT_PACKAGE@">

Gettext domain shouldn't be needed, it's in the right package.
Comment 3 Zeeshan Ali 2014-08-09 15:51:04 UTC 
Created attachment 283012 [details] [review]
Add location settings

Moving location settings from gnome-shell to here because they will now
also be accessed by gnome-control-center.
Comment 4 Bastien Nocera 2014-08-10 11:57:04 UTC 
Review of attachment 283012 [details] [review]:

Looks good.
Comment 5 Zeeshan Ali 2014-08-10 16:55:38 UTC 
Attachment 283012 [details] pushed as 5f944f9 - Add location settings