After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734542 - speexenc: Improve annotation of internal function
speexenc: Improve annotation of internal function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 12:23 UTC by Sebastian Rasmussen
Modified: 2014-08-10 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.13 KB, patch)
2014-08-09 12:24 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 12:23:25 UTC 
Since the internal function calls gst_caps_make_writable() the the input
argument is actually consumed and possibly a copy created. Have the annotations
illustrate this.
Comment 1 Sebastian Rasmussen 2014-08-09 12:24:09 UTC 
Created attachment 282997 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 10:18:14 UTC 
I hope this was the last one of those..

commit 485da06b14d6e20062edb2d471d012ebf569653e
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 14:22:42 2014 +0200

    speexenc: Improve annotation of internal function
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734542