After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734541 - vorbisenc: Improve annotation of internal function
vorbisenc: Improve annotation of internal function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 12:21 UTC by Sebastian Rasmussen
Modified: 2014-08-10 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.20 KB, patch)
2014-08-09 12:22 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 12:21:53 UTC 
Since the internal function calls gst_caps_make_writable() the the input argument is actually consumed and possibly a copy created. Have the annotations illustrate this.
Comment 1 Sebastian Rasmussen 2014-08-09 12:22:30 UTC 
Created attachment 282996 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 09:50:28 UTC 
Shouldn't really have annotations in the first place..

commit 58ec2216082519f98e41a721680a611ba4114e3c
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 14:20:32 2014 +0200

    vorbisenc: Improve annotation of internal function
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734541