After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734534 - vtenc: Avoid leaking caps object and its copy
vtenc: Avoid leaking caps object and its copy
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 11:58 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.45 KB, patch)
2014-08-09 11:58 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 11:58:08 UTC 
gst_pad_get_pad_template_caps() returns a reference which is unreferenced, so creating a copy using gst_caps_copy() results in a reference leak. Also the caps are pushed as an event downstream, but this doesn't consume the caps so it must still be unreferenced. The attached patch aims to fix this issue.
Comment 1 Sebastian Rasmussen 2014-08-09 11:58:46 UTC 
Created attachment 282990 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:24:46 UTC 
commit b323fba934b2dc855bc7226594ed8268022f4cef
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 13:20:41 2014 +0200

    vtenc: Avoid leaking caps object and its copy
    
    gst_pad_get_pad_template_caps() returns a reference which is unreferenced,
    so creating a copy using gst_caps_copy() results in a reference leak. Also
    the caps are pushed as an event downstream, but this doesn't consume the
    caps so it must still be unreferenced.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734534