After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734531 - interlace: Unref pad template caps after usage
interlace: Unref pad template caps after usage
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 11:53 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.11 KB, patch)
2014-08-09 11:54 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 11:53:45 UTC 
gst_pad_get_pad_template_caps() returns a reference to a caps object that must be released after usage. The attached patch aims to fix this issue.
Comment 1 Sebastian Rasmussen 2014-08-09 11:54:20 UTC 
Created attachment 282987 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:26:20 UTC 
The patch looks correct, but the description is a bit bogus as far as I can tell. What this patch fixes is a double-unref / caps refcounting logic bug, no?


commit 7731f3b36ecb2d5d2756c2978e164cf5cc4f8102
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 13:12:14 2014 +0200

    interlace: fix caps refcounting
    
    tcaps was unrefed when it shouldn't have been unrefed
    in some cases.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734531