After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734520 - openal: Unref pad template caps after usage
openal: Unref pad template caps after usage
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 11:39 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.73 KB, patch)
2014-08-09 11:39 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 11:39:17 UTC 
This is another instance of gst_pad_get_pad_template_caps() returning a
reference but the code does not release the reference. The attached patch aims
to fix this.
Comment 1 Sebastian Rasmussen 2014-08-09 11:39:52 UTC 
Created attachment 282978 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:41:12 UTC 
This patch does not even compile...

Fixed it up though:
commit b53433fbbf7e62ad19850bbe178455c17ddd6970
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 01:27:53 2014 +0200

    openal: Unref pad template caps after usage
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734520
Comment 3 Tim-Philipp Müller 2014-08-10 11:41:38 UTC 
Comment on attachment 282978 [details] [review]
Proposed patch.

Committed after fixing it up