After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734519 - ladspa: Unref pad template caps after usage
ladspa: Unref pad template caps after usage
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 11:38 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (809 bytes, patch)
2014-08-09 11:38 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 11:38:01 UTC 
This is another instance of gst_pad_get_pad_template_caps() returning a
reference but the code does not release the reference. The attached patch aims
to fix this.
Comment 1 Sebastian Rasmussen 2014-08-09 11:38:47 UTC 
Created attachment 282977 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:31:02 UTC 
commit 2f8e528f37311ab0dd40e69df2d264619f3eb295
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Aug 10 12:29:04 2014 +0100

    ladspa: fix up broken patch merge
    
    Sorry, should've been commit --amend

commit 4dde56748081bed5e909f438a1c14b9a6a98d240
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 01:25:21 2014 +0200

    ladspa: Unref pad template caps after usage
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734519

commit 9b7314cb6c1ebf437d2345a1e9fc978402fe129f
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 01:25:21 2014 +0200

    ladspa: Unref pad template caps after usage
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734519