After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734514 - GtkDialog: Warn about lack of transient parents
GtkDialog: Warn about lack of transient parents
Status: RESOLVED FIXED
Product: d-feet
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: D-Feet Maintainer(s)
D-Feet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-09 07:23 UTC by Ritesh Khadgaray ( irc:ritz)
Modified: 2017-11-24 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
hack (1.42 KB, patch)
2014-08-09 07:23 UTC, Ritesh Khadgaray ( irc:ritz)
none Details | Review
ExecuteMethodDialog: set_transient_for() (2.38 KB, patch)
2017-11-24 15:45 UTC, Will Thompson
none Details | Review
ExecuteMethodDialog: set_transient_for() (2.38 KB, patch)
2017-11-24 15:46 UTC, Will Thompson
none Details | Review

Description Ritesh Khadgaray ( irc:ritz) 2014-08-09 07:23:21 UTC
Created attachment 282962 [details] [review]
hack

GtkDialog: Warns about lack of transient parents when running d-feet
Comment 1 Thomas Bechtold 2015-06-21 12:10:23 UTC
Partly solved. Still need to set the parent for method execute dialog.
Comment 2 Will Thompson 2017-11-24 15:45:35 UTC
Created attachment 364337 [details] [review]
ExecuteMethodDialog: set_transient_for()

Without this, we see:

    Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

You currently cannot actually interact with the toplevel application
window while an ExecuteMethodDialog is visible; this change also makes
this fact visible to the user.
Comment 3 Will Thompson 2017-11-24 15:46:00 UTC
Created attachment 364338 [details] [review]
ExecuteMethodDialog: set_transient_for()

Without this, we see:

    Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

You currently cannot actually interact with the toplevel application
window while an ExecuteMethodDialog is visible; this change also makes
this fact visible to the user.
Comment 4 Thomas Bechtold 2017-11-24 18:50:18 UTC
Applied and pushed. Thanks!