GNOME Bugzilla – Bug 734352
Session chooser menu too short
Last modified: 2016-01-12 21:56:42 UTC
We're running fedora 20 in a computer lab and try to provide a lot of session for our users. But it is not possible to choose all of them, since the session chooser menu is too short to show all of them. There's a scroll bar missing or the chooser menu should open on top of the screen.
can you say how many sessions you want to offer ? A screenshot would also be helpful.
Created attachment 282697 [details] screenshot of all sessions
We have 22 sessions
I want to confirm this issue. My screen has a lower resolution than the one in the attached screenshot and consequently the list is even shorter.
Is there a solution? I think it would be simple for the maintainers to enable a scrollbar for a pulldown-menu in the source code. The patch should be applicable to all versions since 3.12.x, because the problem affects all current fedora versions. This is a very long time without reaction for a simple solvable problem. This bug report seems to describe the same problem as bug 741918.
Florian, can we pop up the menu to the right instead of the bottom when it has more than, say 10 items ? That should give us enough room for 20-30 sessions.
*** Bug 741918 has been marked as a duplicate of this bug. ***
Created attachment 299949 [details] [review] loginDialog: Move long session-list menus to the side Currently the menu position below the button means that the menu can extend to roughly half the screen height before ending up partly off-screen. This is plenty of space for commonly installed sessions, but some users have a significantly higher number of sessions in the list. Move the menu to the side of the button in that case to maximize the vertical space the menu may take up.
Review of attachment 299949 [details] [review]: ::: js/gdm/loginDialog.js @@ +50,3 @@ const _TIMED_LOGIN_IDLE_THRESHOLD = 5.0; const _LOGO_ICON_HEIGHT = 48; +const _MAX_BOTTOM_MENU_ITEMS = 10; I would lower this to 5 which is already more than any sensible installation would have. I'm thinking of testing in VMs where the monitor size is more likely to be small and the number of sessions big and as such perhaps 10 is still too much to fit below the button? Do we also want to consider vertically oriented monitors? :-)
In Fedora at least, some DEs create several menu entries. For example, I have 5 DEs installed (GNOME, KDE, MATE, Cinnamon, Basic) and the entries I can read are awesome Cinnamon Cinnamon (Software Rendering) dwm GNOME GNOME Classic GNOME on Wayland i3 In particular, Basic creates around half a dozen entries (don't ask me why). Should the Version for this bug be set to 3.15.x since that's affected (and was the Version on my duplicate bug)?
(In reply to Rui Matos from comment #9) > Review of attachment 299949 [details] [review] [review]: > > ::: js/gdm/loginDialog.js > @@ +50,3 @@ > const _TIMED_LOGIN_IDLE_THRESHOLD = 5.0; > const _LOGO_ICON_HEIGHT = 48; > +const _MAX_BOTTOM_MENU_ITEMS = 10; > > I would lower this to 5 which is already more than any sensible installation > would have. Sure. I used 4 in my first test attempt, just to be reminded that I don't have actually have more than that (and that's including a custom jhbuild session) ... > Do we also want to consider vertically oriented monitors? :-) Not sure, is it worth the code? The limit could be higher there (or even unlimited?), but then the proposed limit of 5 is unlikely enough. Or do you mean a session like "Enlightenment Special Preview Edition (Software renderer)" could bring us in trouble with regard to screen width? Something else though - should we change the menu alignment as well? At least to me, menus that point left/right look nicer when vertically centered ...
(In reply to Florian Müllner from comment #11) > Something else though - should we change the menu alignment as well? At > least to me, menus that point left/right look nicer when vertically centered Ah, yes that's a good idea
Created attachment 299973 [details] [review] loginDialog: Move long session-list menus to the side Updated limit and alignment.
First, thanks for working on a solution. I am not an expert in interface programming. But I want to note that a fixed limit cannot fit to all display sizes. Wouldn't it be better to compute the maximum number of menu items vertically or horizontally depending on the size of the visible screen, and use the fixed number only as fallback value when the screen size is unknown? This would also solve the problem whether we have a vertically or horizontally oriented monitor or a small or big one. I don't know internal details of gnome-shell, but is there a reason not to use a scrollbar when there are to much items to fit on the screen, as we had in previous gnome releases? Depending on the size and resolution of the monitor and how much desktops are installed, there may be always a (smaller or bigger) number of items so that the menu will not fit on the screen. Here an explanation why our list of session managers has many items: We have varying users, students, staff, with different preferences and experience. Most of them use gnome oder kde, but some of them like to use the session manager they already know or like. It is less expensive for me to install (nearly) all available session managers on the computers in advance, instead of doing a later (individual) install of the requested desktop (and software in general) for every individual requirements. This is the reason why our session chooser menu has many items.
Review of attachment 299973 [details] [review]: looks good, let's keep this simple
Attachment 299973 [details] pushed as 9934529 - loginDialog: Move long session-list menus to the side
*** Bug 757914 has been marked as a duplicate of this bug. ***