After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734343 - monitor-manager-xrandr: Fix some wrong variable type and calculation.
monitor-manager-xrandr: Fix some wrong variable type and calculation.
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-06 09:58 UTC by Shih-Yuan Lee (FourDollars)
Modified: 2015-06-27 07:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix some wrong variable type and calculation. (1.70 KB, patch)
2014-08-06 09:58 UTC, Shih-Yuan Lee (FourDollars) 		needs-work Details | Review
Fix some wrong variable type and calculation. (1.40 KB, patch)
2014-08-07 02:25 UTC, Shih-Yuan Lee (FourDollars) 		none Details | Review

Description Shih-Yuan Lee (FourDollars) 2014-08-06 09:58:57 UTC 
Created attachment 282645 [details] [review]
Fix some wrong variable type and calculation.

This fixes some wrong variable type and wrong calculation.
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-08-06 12:35:37 UTC 
Review of attachment 282645 [details] [review]:

::: src/backends/x11/meta-monitor-manager-xrandr.c
@@ +143,3 @@
                                 MetaOutput               *output)
 {
+  int value;

No, this is already the correct type.
Comment 2 Shih-Yuan Lee (FourDollars) 2014-08-07 02:22:16 UTC 
You are probably right.
My patch is not complete.
Comment 3 Shih-Yuan Lee (FourDollars) 2014-08-07 02:25:39 UTC 
Created attachment 282751 [details] [review]
Fix some wrong variable type and calculation.
Comment 4 Jasper St. Pierre (not reading bugmail) 2015-06-27 07:37:18 UTC 
This was fixed at some point.