After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734053 - gtkcairoblur: Replace our exponential blur with the box blur from mutter
gtkcairoblur: Replace our exponential blur with the box blur from mutter
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-07-31 15:41 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2014-08-03 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkcairoblur: Replace our exponential blur with the box blur from mutter (10.74 KB, patch)
2014-07-31 15:41 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2014-07-31 15:41:37 UTC 
See patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-07-31 15:41:40 UTC 
Created attachment 282170 [details] [review]
gtkcairoblur: Replace our exponential blur with the box blur from mutter
Comment 2 Alexander Larsson 2014-07-31 16:01:37 UTC 
Review of attachment 282170 [details] [review]:

Seems good to me with minor nit

::: gtk/gtkcairoblur.c
@@ +115,3 @@
+/* Swaps width and height. Either swaps in-place and returns the original
+ * buffer or allocates a new buffer, frees the original buffer and returns
+ * the new buffer.

No, it never allocates, you always pass in the preallocated dest buffer.
Comment 3 Matthias Clasen 2014-08-02 22:50:57 UTC 
Attachment 282170 [details] pushed as f5d8f75 - gtkcairoblur: Replace our exponential blur with the box blur from mutter
Comment 4 Giovanni Campagna 2014-08-03 09:32:08 UTC 
The added file is GPL, which effectively makes the whole GTK+ under GPL.
A relicense from the copyright holder (Red Hat, according to the comments) is necessary, as well as auditing that no-one else modified that code significantly while it was in mutter.