After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733996 - afp backend uses incorrect encoding for volume names
afp backend uses incorrect encoding for volume names
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afp backend
1.21.x
Other Linux
: Normal minor
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-30 16:24 UTC by Ross Lagerwall
Modified: 2014-09-27 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afp: Use UTF-8 for volume names (5.52 KB, patch)
2014-07-30 20:01 UTC, Ross Lagerwall 		committed Details | Review

Description Ross Lagerwall 2014-07-30 16:24:40 UTC 
For example, the user sees: John’s Public Folder
Comment 1 Ross Lagerwall 2014-07-30 20:01:26 UTC 
Created attachment 282105 [details] [review]
afp: Use UTF-8 for volume names

Use UTF-8 for volume names since volume names are encoded as UTF-8 for
protocol versions 3.0 and higher.  This prevents seeing volume names
like: "John’s Public Folder"

Since the volume name comes as a pascal string with UTF-8 encoding,
extend the function to read pascal strings with the ability to read
pascal strings encoded as UTF-8.
Comment 2 Ondrej Holy 2014-09-17 08:53:34 UTC 
Review of attachment 282105 [details] [review]:

It looks good if you tested it, however shouldn't we check the protocol version?
Comment 3 Ross Lagerwall 2014-09-17 13:44:26 UTC 
(In reply to comment #2)
> Review of attachment 282105 [details] [review]:
> 
> It looks good if you tested it, however shouldn't we check the protocol
> version?

Yeah, I tested it :-)

The AFP backend only supports version 3.0+, see get_server_info() in gvfsafpserver.c.
Comment 4 Ondrej Holy 2014-09-17 15:15:17 UTC 
Comment on attachment 282105 [details] [review]
afp: Use UTF-8 for volume names

So it's correct :-)
Comment 5 Ross Lagerwall 2014-09-27 08:39:52 UTC 
Pushed to master as c6200ea2184b63016fe573155b0480ba88069456. Thanks for the review!