After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733929 - EasyTAG chokes on Ogg Vorbis files with duplicate tags
EasyTAG chokes on Ogg Vorbis files with duplicate tags
Status: RESOLVED FIXED
Product: easytag
Classification: Other
Component: general
2.2.x
Other Linux
: Normal normal
: 2.2
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-29 16:01 UTC by Tristan Miller
Modified: 2014-08-01 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing error dialog (22.18 KB, image/png)
2014-07-30 12:07 UTC, Tristan Miller
Details

Description Tristan Miller 2014-07-29 16:01:34 UTC
A different bug in EasyTag (Bug 733928) causes it to write multiple versions of the same tag to Ogg Vorbis files.  Once a file has been borked in this way, EasyTag can no longer write to it.  If you attempt to edit a tag in such a file, EasyTAG pops up the following error dialog, which isn't particularly informative:

Tag Write Error

Cannot write tag in file 'foo.ogg'

(null)

[ Close ]

See Bug 733928 for instructions on how to get EasyTAG to produce a file with multiple Title tags.  I can also attach such a file here on request.
Comment 1 Tristan Miller 2014-07-29 16:02:02 UTC
I should add that the error occurs when using EasyTAG 2.2.3.
Comment 2 David King 2014-07-30 07:32:23 UTC
It seems like an error is being created without an appropriate associated message. Is the "close" in your reproduction instructions a crash? If so, a stack trace would be useful. Alternatively, please attach the file that causes problems and I can investigate further.
Comment 3 Tristan Miller 2014-07-30 12:07:42 UTC
Created attachment 282028 [details]
Screenshot showing error dialog

No, the "[ Close ]" was just my way of depicting the error dialog's close button as text.  See the attached screenshot.
Comment 4 Tristan Miller 2014-07-30 12:12:57 UTC
I can't attach the file that causes the problems because it's too large.  However, you can download it here: <http://files.nothingisreal.com/tmp/Matthias%20Le%20Bidan%20-%20Frozen-Bubble%20-%202P%20Game%20Music%20(new%20version).ogg>
Comment 5 David King 2014-07-31 07:57:34 UTC
I cannot reproduce the problem here, as the file loads fine, joining the multiple tags into a single field. Do you have the latest versions of libogg and vorbisfile installed?
Comment 6 Tristan Miller 2014-07-31 08:14:19 UTC
I'm running the latest version of openSUSE (13.1), which provides libogg 1.3.0 and libvorbisfile 1.3.3.  The latest versions available from Xiph.org are 1.3.2 and 1.3.4, respectively.
Comment 7 Tristan Miller 2014-07-31 08:31:53 UTC
I just installed libogg 1.3.1 and libvorbisfile 1.3.4 from openSUSE's Factory repository.  I'm still getting the "(null)" error message when trying to write the Title tag of this file.

If you think it would help, I can try installing libogg 1.3.2 from source and see if that fixes things.
Comment 8 David King 2014-08-01 14:36:51 UTC
I am using libogg 1.3.0 and libvorbisfile 1.3.4, so its possible that the libvorbisfile difference is the cause of the problem. I will try to prepare an updated package. My steps to reproduce are:

1. start EasyTAG showing the provided file with a multi-artist tag field (tag splitting is disabled in the preferences)
2. set the album artist field to 'a'
3. save the tag

The tag saves successfully and examining the file with vorbiscomment shows a single title field in the tags of the newly-saved file.
Comment 9 David King 2014-08-01 14:38:20 UTC
(In reply to comment #8)
> I am using libogg 1.3.0 and libvorbisfile 1.3.4, so its possible that the
> libvorbisfile difference is the cause of the problem.

The libogg version difference , not the libvorbisfile one, of course!
Comment 10 Tristan Miller 2014-08-01 15:11:10 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > I am using libogg 1.3.0 and libvorbisfile 1.3.4, so its possible that the
> > libvorbisfile difference is the cause of the problem.
> 
> The libogg version difference , not the libvorbisfile one, of course!

I don't see how that could be the case, given that I tested with both libogg 1.3.0 (i.e., the same version you are using) and libogg 1.3.1.

I did some further poking around and I discovered the true cause of the problem: the file wasn't user-writeable!  After chmod u+w I was able to successfully write the tag.

However, the error message produced by EasyTAG still needs to be fixed.  Had it told me "File isn't writable" instead of "(null)" then I wouldn't have mistakenly assumed that the problem had to do with the double Title tag. :)
Comment 11 David King 2014-08-01 16:46:57 UTC
Thanks for the extra information, I fixed this on the master and easytag-2-2 branches as aafa2f280cd38621835c8919315d07165639a0db and 4288ddf6c7c5b09d352cdce784088e263d332501.