After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733872 - codecparsers: mpegvideo: Add more fields to the headers.
codecparsers: mpegvideo: Add more fields to the headers.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 734547
 
 
Reported: 2014-07-28 15:17 UTC by sreerenj
Modified: 2016-04-14 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
codecparsers: mpegvideo: Add more fields to the GstMpegVideoSequenceHdr (3.30 KB, patch)
2014-07-28 15:20 UTC, sreerenj
committed Details | Review
codecparsers: mpegvideo: Add vbv_delay field to PictureHeader (1.55 KB, patch)
2014-07-28 15:20 UTC, sreerenj
committed Details | Review
codecparsers: mpegvideo: Parse more slice header fields (2.96 KB, patch)
2014-07-28 15:20 UTC, sreerenj
committed Details | Review

Description sreerenj 2014-07-28 15:17:41 UTC
Adding a couple of missing fields to SequenceHdr, PictureHdr and SliceHdr
Comment 1 sreerenj 2014-07-28 15:20:00 UTC
Created attachment 281872 [details] [review]
codecparsers: mpegvideo: Add more fields to the GstMpegVideoSequenceHdr
Comment 2 sreerenj 2014-07-28 15:20:25 UTC
Created attachment 281873 [details] [review]
codecparsers: mpegvideo: Add vbv_delay field to PictureHeader
Comment 3 sreerenj 2014-07-28 15:20:46 UTC
Created attachment 281874 [details] [review]
codecparsers: mpegvideo: Parse more slice header fields
Comment 4 Jan Schmidt 2016-04-14 15:27:06 UTC
Thanks, pushed to master (sorry for the absurd delay):

commit 8f853cfed59fb0a38c4e5b534ab7fbe22682ca9c
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Mon Jul 28 12:14:02 2014 +0300

    codecparsers: mpegvideo: Parse more slice header fields
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733872

commit 51c75260305f171ea5b760f159451296df35895f
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Mon Jul 28 11:17:05 2014 +0300

    codecparsers: mpegvideo: Add vbv_delay field to PictureHeader
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733872

commit 7b0b74041ed24b4b7ab4cfb0217059cd88f4b72e
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Mon Jul 28 11:14:22 2014 +0300

    codecparsers: mpegvideo: Add more fields to the GstMpegVideoSequenceHdr
    
    Added the fields load_non_intra_quantiser_matrix and
    load_chroma_intra_quantiser_matrix to the sequence header structure.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733872
Comment 5 Tim-Philipp Müller 2016-04-14 15:42:41 UTC
This breaks ABI of course, just for the record. Which is ok, but should make sure we add a note to the 1.10 release notes about that ;)
Comment 6 sreerenj 2016-04-14 15:48:28 UTC
Aha very old patches, was not even in my distant memory !
Added those for codec analyzer in gst-devtools.