GNOME Bugzilla – Bug 733840
Activities button no longer works
Last modified: 2014-08-01 09:41:24 UTC
Since the commit: commit 38d05a8285a59a63a056d028fa4f29b664137ed2 Author: Carlos Garnacho <carlosg@gnome.org> Date: Tue Jul 22 12:32:39 2014 +0200 panel: Make the "Activities" button react to touch events https://bugzilla.gnome.org/show_bug.cgi?id=733633 Clicking on the Activities button with the mouse doesn't work on some, possibly all, systems. (I saw this in a VM, and someone showed it to me on their desktop ... I haven't tried on my main system.) The observed problem is that the shell starts entering the overview, the immediately kicks back out. Triggering the overview with the Super key works fine. Reverting the patch resolves the problem.
I saw the issue in both my jhbuild environment and in a gnome-continuous VM; also pushing the mouse in the top left corner still works.
Created attachment 282169 [details] [review] panel: Avoid _onEvent() to be called twice Both Panel.ActivitiesButton and its parent class Panel.MenuButton would attempt to connect their own _onEvent() function to Clutter::event, which counterintuitively was connecting the child class' _onEvent() function twice. So, actually chain up on the signal handler, and don't connect twice to the signal. Both methods were calling this.menu.close(), so only do that on the parent class handler, since we're chaining up and doing the right thing now.
Review of attachment 282169 [details] [review]: LGTM
Attachment 282169 [details] pushed as a6d8c25 - panel: Avoid _onEvent() to be called twice
*** Bug 734103 has been marked as a duplicate of this bug. ***