After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733830 - While extracting music from CDs, information in the "Year" field is lost
While extracting music from CDs, information in the "Year" field is lost
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
3.0.x
Other Linux
: Normal minor
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 746293 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-07-27 18:56 UTC by Nicholas H
Modified: 2015-12-25 06:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes the bug (1.16 KB, patch)
2015-12-20 10:51 UTC, Yann R.
none Details | Review

Description Nicholas H 2014-07-27 18:56:19 UTC
With Sound Juicer installed, Rhythmbox can rip CDs. When a CD is inserted and selected, it displays editable information, including the year of the release (which is often automatically filled in from MusicBrainz). 
When the "Extract" button is clicked in Rhythmbox, it copies these files to the library, including their metadata, but the information in the year field is lost. After the CD has been extracted, the songs in the library list the year as "Unknown".
Comment 1 Nicholas H 2014-08-04 16:18:26 UTC
The "Sort Artist" field is also ignored on extracting media.
Comment 2 Luis Henrique Mello 2014-10-31 01:38:54 UTC
I'm also having this issue. BTW is the "Sort Artist" field ever used anywhere?
Comment 3 Nicholas H 2014-10-31 01:46:16 UTC
As far as I have used it, the sort artist field is used to sort the artist (yeah, it's basically as it's labelled). 
For instance, if you change the Sort Artist of an artist named "Aardvark" to "Zoo" then it'll be located after "Zodiac" when you sort your music by artist, instead of being up with the A's before "Apple".
Comment 4 Luis Henrique Mello 2014-12-02 06:49:04 UTC
Well, I just ripped a CD to FLAC format today. The 'Sort Artist' field was preserved, only the 'year' is lost.

Guess we should rip to every format available to check this?
Comment 5 Luis Henrique Mello 2014-12-02 07:18:41 UTC
On ripping to m4a VBR, the year is preserved but the "Sort Artist" is ignored not in the sense of not showing anything, but no matter what you write on "Sort Artist" the information gathered from MusicBrainz overrides it.
Comment 6 Jonathan Matthew 2015-03-28 22:47:56 UTC
*** Bug 746293 has been marked as a duplicate of this bug. ***
Comment 7 Yann R. 2015-12-20 10:51:41 UTC
Created attachment 317687 [details] [review]
Patch that fixes the bug

I have recently encountered this bug and see that it has been reported 1.5 year ago and it still has not been fixed in git master!

I have look into the RB source code and found a simple solution.

This patch fixes the missing year tag both for MP3 files and FLAC files. I haven't tested other file formats (like Ogg) but I think it should work too.

Details:
Apparently, Gstreamer has two date tags GST_TAG_DATE (type GDate) and GST_TAG_DATE_TIME (type GstDateTime). RB only sets the first one, and I guess that the tag setter used by RB is just reading the other one (bad luck).
This patch makes RB sets both gst date tags, so we don't care which date tags is read by the tag setter.
Comment 8 Jonathan Matthew 2015-12-25 06:52:44 UTC
pushed as commit f7b3610; thanks for figuring out what was going wrong here.  I adjusted the code style a bit and also added the missing gst_date_time_unref to avoid leaking the GstDateTime object.