GNOME Bugzilla – Bug 733813
Style the search entry using a class
Last modified: 2014-08-19 13:30:05 UTC
Hello! The current implementation of the overview search bar is styled by ID (#searchEntry on gnome-shell.css). It should be styled using a class (maybe .searchEntry ?), to allow extension developers to grab the style of it. In the way it is now, the developer has to 1) duplicate all the CSS for #searchEntry to its stylesheet.css file (ie, hardcode the default theme on its extension) or 2) give to its search entry the same ID as the theme (but we all know that an ID must belong to only one element). Cheers, Ian.
Created attachment 282240 [details] [review] SearchEntry: replace the ID with a style class This way extension authors can create entries that look and feel like the overview search entry. You can actually have two actors with the same name, but ok, it's easy enough to fix this.
Review of attachment 282240 [details] [review]: Looks fine ::: js/ui/overview.js @@ +243,3 @@ this._overview.add_actor(this._panelGhost); + this._searchEntry = new St.Entry({ style_class: 'search-entry', The name could be kept here. No big deal though
Attachment 282240 [details] pushed as 3842981 - SearchEntry: replace the ID with a style class