GNOME Bugzilla – Bug 733682
waylandsink: allow catching input events
Last modified: 2014-11-08 14:14:53 UTC
Created attachment 281604 [details] [review] waylandsink: allow catching input events In case that waylandsink is used in "stand-alone" mode (i.e. not in an application), it should catch the input events. A basic test is to be able to move the window when using gst-launch videotestsrc ! waylandsink
Hello, do you have comments on this patch ?
Hello, I am fine with that patch, given that you have tested it and works ok. I am not confident yet with the input event handling in general, because I haven't studied that part enough yet and I have seen problems in strange interactions with the embedder toolkit, but for the standalone mode it should be fine. I only have one comment regarding the code of the patch, I would prefer it if you used gst_wl_window_is_toplevel() in the if() check instead of using window->display->own_display. At the moment both checks have the same effect, but I'd rather maintain the state of the window inside the window class instead of looking at the internals of the display class.
I just test with gst_wl_window_is_toplevel() but it doesn't work. I don't catch the link between using waylandsink in "stand-alone" and check if the window is on top.
(In reply to comment #3) > I just test with gst_wl_window_is_toplevel() but it doesn't work. Ah, I guess this function is being called too early, when the shell_surface is still NULL. I have a pending commit around which modifies this logic a bit... > I don't catch the link between using waylandsink in "stand-alone" and check if > the window is on top. This is the definition for me. "stand-alone" means not embedded inside another window (therefore, it's a top-level window), no? You can commit it as it is and I will adjust it as soon as I push my pending changes... Possibly next week. Thanks.
Comment on attachment 281604 [details] [review] waylandsink: allow catching input events George, can you just merge that into your pending changes and push it with them?
commit 4395c02b9634b353d57a630db69b188394bb148b Author: Tifaine Inguere <tifaine.inguere@st.com> Date: Thu Jul 24 16:53:53 2014 +0200 waylandsink : Allow surface to catch input events If waylandsink is the owner of the display then it is in charge of catching input events on the surface. https://bugzilla.gnome.org/show_bug.cgi?id=733682 Signed-off-by: Tifaine Inguere <tifaine.inguere@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>