After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733507 - orientation plugin fixes
orientation plugin fixes
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-21 14:40 UTC by Bastien Nocera
Modified: 2014-07-23 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
orientation: Unown the D-Bus name on Stop (1.52 KB, patch)
2014-07-21 14:40 UTC, Bastien Nocera
committed Details | Review
orientation: Fix plugin on MS Surface devices (6.16 KB, patch)
2014-07-21 14:40 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2014-07-21 14:40:49 UTC
Those are fixes necessary to make it work on the MS Surface tablets.
Comment 1 Bastien Nocera 2014-07-21 14:40:53 UTC
Created attachment 281316 [details] [review]
orientation: Unown the D-Bus name on Stop

Instead of when finalizing the plugin, so that stop and starting
the plugin again works as expected.
Comment 2 Bastien Nocera 2014-07-21 14:40:58 UTC
Created attachment 281317 [details] [review]
orientation: Fix plugin on MS Surface devices

When plugging in the type/touch cover on a Microsoft Surface, the
IIO sensor is unplugged, and plugged in again with a different
sysfs path. As the accelerometer comes and goes, we need to handle this
in the orientation plugin, and not bail out if we can't find the
accelerometer on startup, and handle devices coming and going.
Comment 3 Rui Matos 2014-07-22 08:56:59 UTC
Review of attachment 281316 [details] [review]:

ok
Comment 4 Rui Matos 2014-07-22 09:02:06 UTC
Review of attachment 281317 [details] [review]:

Can't test but looks good.
Comment 5 Reyad Attiyat 2014-07-22 23:35:43 UTC
I have tested both patches that Bastien has posted and they work as expected on my Surface Pro 2.

Thank You