After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733502 - [PATCH] Bug when height > width
[PATCH] Bug when height > width
Status: RESOLVED FIXED
Product: iagno
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: iagno-maint
iagno-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-21 12:58 UTC by Arnaud B.
Modified: 2014-07-21 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use an AspectFrame to ensure all looks good. (1010 bytes, patch)
2014-07-21 13:02 UTC, Arnaud B. 		committed Details | Review
Screenshot (149.77 KB, image/png)
2014-07-21 13:04 UTC, Arnaud B. 		  Details

Description Arnaud B. 2014-07-21 12:58:32 UTC 
For many times, Iagno bugs with “vertical windows” (when the height is more than the width), as in this screenshot of the master branch. I’ve looked to other games, but didn’t find a good solution; usually, the game board is just put inside an AspectFrame with a ratio of 1. I suggest putting both the board and the right column in the AspectFrame, with a ratio of 1,3 or so. Here is the patch.

By the way, I have a GtkBuilder version of Iagno, not up-to-date but it’s not so complicated to do. Are you interested ?
Comment 1 Arnaud B. 2014-07-21 13:02:31 UTC 
Created attachment 281308 [details] [review]
Use an AspectFrame to ensure all looks good.

The screenshot comes after in fact. ^^
Comment 2 Arnaud B. 2014-07-21 13:04:48 UTC 
Created attachment 281309 [details]
Screenshot
Comment 3 Michael Catanzaro 2014-07-21 14:15:36 UTC 
Thanks, much better.

A GtkBuilder patch would indeed be welcome (if it's up-to-date with the current version of the UI). Pay attention to the interface-requires comment at the top; that'll need to be set to 3.10 for header bars, or 3.12 for the use-header-bar property you'll need for the preferences dialog.

Attachment 281308 [details] pushed as 9587938 - Use an AspectFrame to ensure all looks good.