After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733432 - Photo/video path fallback doesn't work.
Photo/video path fallback doesn't work.
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
: 731032 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-07-20 00:24 UTC by Benjamin Herr
Modified: 2014-07-20 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the issue. (1.12 KB, patch)
2014-07-20 00:24 UTC, Benjamin Herr 		none Details | Review
check XDG video and photo path explicitly (3.61 KB, patch)
2014-07-20 07:39 UTC, David King 		committed Details | Review

Description Benjamin Herr 2014-07-20 00:24:42 UTC 
Created attachment 281214 [details] [review]
Fixes the issue.

Cheese appears to be unable to save captured photos, or videos, if XDG_PHOTO, or XDG_VIDEO, and org.gnome.Cheese.photo-path, or .video-path, are not set. It also doesn't display previously taken photos in the gallery thing at the bottom.
Comment 1 David King 2014-07-20 07:39:07 UTC 
Created attachment 281225 [details] [review]
check XDG video and photo path explicitly

It's probably better to directly check the return value of g_get_user_special_dir(), as it is documented to return NULL on failure. Does the attached patch work for you? If so, I can write a test that checks the behaviour is correct when the relevant. XDG variables are not set
Comment 2 Benjamin Herr 2014-07-20 11:54:52 UTC 
Yeah, that patch works for me. Thank you!
Comment 3 David King 2014-07-20 18:31:17 UTC 
*** Bug 731032 has been marked as a duplicate of this bug. ***
Comment 4 David King 2014-07-20 18:32:06 UTC 
Comment on attachment 281225 [details] [review]
check XDG video and photo path explicitly

Pushed to master as 589c9291fc37ab088003685ea3d874976cc5b0ea.