GNOME Bugzilla – Bug 733313
Reduce header-bar text-button padding for Nautilus
Last modified: 2014-07-30 10:37:28 UTC
Text buttons in header-bars have a lot of padding on left & right sides (both in the old Adwaita, and again in the new Adwaita as of e084e5c). This is generally fine in most places, but IMHO there should be an exception for path bars like Nautilus has. I usually use small Nautilus windows ~750-850px wide (and when tiled to half the screen, it's only ~680px). Where 3-6 buttons used to fit (before e084e5c), with the padding I often see only 1-3 of them. [It doesn't help that Nautilus also doesn't use all space in the headerbar, but always leaves about an inch unused.] It's not *too* bad, and of course it depends a lot on how long the folder names are, but overall I wouldn't call it an improvement. Also, since the buttons represent just components of the same path string, the wide spaces between them make it a little bit harder to read the whole path at once... --- Continuing from discussion on IRC: (Lapo) grawity: yeah I see, I can reduce it for the pathbar tho (Lapo) grawity: uhm, I could squize those buttons when the window is tiled, anyway nautilus seems not to use all available space for the pathbar (Lapo) with more padding the buttons there looks a whole lot better and works better too (bigger target) in most cases but when the space is tight (Lapo) yeah, problem is that I don't know when the window is "small" by the time hence it should be general (Lapo) also nautilus doesn't use a plain GtkPathBar so I can't special case that in Adwaita (Lapo) uhm, a .path-bar class could be usefull (Lapo) mclasen: a .path-bar class could be usefull since nautilus doesn't actually use gtkpathbar (Lapo) mclasen: I added back old adwaita padding to header-bar text buttons, when there's no much available space (as in tiled case) it would be nice to squeeze that padding a bit to fit more buttons (Lapo) mclasen: this one may be tricky, but it could be usefull to have a class on the toplevel windows when a window is, well, small, say smaller then an hardcoded size (Lapo) se we could do some padding squeezing by the theme, just an idea (mclasen) define small (Lapo) that has to be defined indeed (Lapo) thinking about width mostly (Lapo) and portrait orientation (Lapo) usefull mostly for pathbars, stackswitcher button strip and tabs (Lapo) mclasen: say < 800 px width (mclasen) not convinced (mclasen) the one thing we can do without arbitrary limits is to say 'this headerbar is smaller than its natural size' (Lapo) mclasen: what's the natural size tho? (Lapo) I'm not convinced as well tbh
I reduced the padding on the pathbars, mostly playing with padding between linked buttons, I think the issue is mitigated now, close the bug if you think it's ok.
Oh, completely forgot about this one. Yes, now it's much better overall; Nautilus and the GTK file picker now look similar too, which is also nice. (Although I'm still not entirely sure about the asymmetric margins in :first/:last, but it's good enough.) Thanks!