After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733227 - Small bottom padding on notifications dialog
Small bottom padding on notifications dialog
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Notifications
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-15 22:24 UTC by alex diavatis
Modified: 2014-07-16 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Small bottom padding (144.73 KB, image/png)
2014-07-15 22:24 UTC, alex diavatis 		  Details
notifications: Fix the padding in the edit dialog (976 bytes, patch)
2014-07-15 22:28 UTC, Yosef Or Boczko 		committed Details | Review
Screenshot - the edit dialog in the notifcation panel after the patch (133.99 KB, image/png)
2014-07-15 22:39 UTC, Yosef Or Boczko 		  Details

Description alex diavatis 2014-07-15 22:24:05 UTC 
Created attachment 280760 [details]
Small bottom padding 

As it seems in screenshot
Comment 1 Yosef Or Boczko 2014-07-15 22:28:48 UTC 
Created attachment 280761 [details] [review]
notifications: Fix the padding in the edit dialog
Comment 2 Yosef Or Boczko 2014-07-15 22:39:15 UTC 
Created attachment 280763 [details]
Screenshot - the edit dialog in the notifcation panel after the patch
Comment 3 Bastien Nocera 2014-07-16 10:40:29 UTC 
Review of attachment 280761 [details] [review]:

Looks good, but why are you changing the right margin as well?
Comment 4 Yosef Or Boczko 2014-07-16 13:53:53 UTC 
Review of attachment 280761 [details] [review]:

Pushed as b37d6ff - notifications: Fix the padding in the edit dialog

I changed the right margin-end too because it was wrong (look on the
two screenshot again).
Comment 5 Bastien Nocera 2014-07-16 13:58:18 UTC 
(In reply to comment #4)
> Review of attachment 280761 [details] [review]:
> 
> Pushed as b37d6ff - notifications: Fix the padding in the edit dialog
> 
> I changed the right margin-end too because it was wrong (look on the
> two screenshot again).

In which case your commit message should mention it, instead of completely ignoring it, and making it look like a cut'n'paste typo.
Comment 6 Yosef Or Boczko 2014-07-16 14:49:29 UTC 
The commit message is „ Fix the padding in the edit dialog” and not
„Fix the padding in the bottom in the edit dialog”, so I think it ok.