After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732919 - srcdir != builddir issue with latest git
srcdir != builddir issue with latest git
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-08 18:48 UTC by Colin Walters
Modified: 2014-07-09 07:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix srcdir != builddir (4.10 KB, patch)
2014-07-08 20:21 UTC, Stefano Facchini
committed Details | Review

Description Colin Walters 2014-07-08 18:48:58 UTC
https://git.gnome.org/browse/gnome-continuous/commit/?id=1da5028607aafa250e74aa2f1fb9fd49114675b0

See: http://build.gnome.org/continuous/buildmaster/builds/2014/07/08/34/build/log-baobab.txt

Unfortunately this is likely hard to fix because it runs into vala + srcdir!=builddir + git issues that have come up in multiple places, though I don't have a link to hand.

The core issue is Vala's automake rules do "cd $(builddir)" which then breaks all relative references in the makefile for $(srcdir).

We may have to just disable srcdir != builddir for baobab.
Comment 1 Stefano Facchini 2014-07-08 20:21:36 UTC
Created attachment 280184 [details] [review]
Fix srcdir != builddir

This partially reverts commit 28b322ce4d583304d8ded89029440915a8176f08.
Comment 2 Stefano Facchini 2014-07-08 20:24:08 UTC
This should fix the issue, even if, not being familiar with ostree/gnome-continuous, I don't understand why it's so nice to have srcdir != builddir :)
Comment 3 Colin Walters 2014-07-08 22:37:42 UTC
Review of attachment 280184 [details] [review]:

Maybe.  I can't tell offhand whether this will fix it, but feel free to push a revert of https://git.gnome.org/browse/gnome-continuous/commit/?id=1da5028607aafa250e74aa2f1fb9fd49114675b0 after this lands in git, and watch #testable to see if it worked.
Comment 4 Stefano Facchini 2014-07-09 07:32:38 UTC
Comment on attachment 280184 [details] [review]
Fix srcdir != builddir

Attachment 280184 [details] pushed as f17e43f - Fix srcdir != builddir