After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732758 - rtph264pay: don't include trailing zero bytes in SPS/PPS
rtph264pay: don't include trailing zero bytes in SPS/PPS
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.2.4
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-05 06:21 UTC by Philip Craig
Modified: 2018-11-03 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (592 bytes, patch)
2014-07-05 06:21 UTC, Philip Craig 		none Details | Review
baseparse: fix taglist update spam (1.49 KB, patch)
2017-08-24 15:05 UTC, Tim-Philipp Müller 		none Details | Review

Description Philip Craig 2014-07-05 06:21:48 UTC 
Created attachment 279940 [details] [review]
Proposed fix

When using 4 byte start codes, rtph264pay includes the first byte of the following start code in the SPS/PPS.  This results in the following warnings from h264parse:

0:00:00.019519088  3198  0x9b74cf0 DEBUG      codecparsers_h264 gsth264parser.c:1721:gst_h264_parse_pps: parsing PPS
0:00:00.019526060  3198  0x9b74cf0 DEBUG      codecparsers_h264 gsth264parser.c:230:nal_reader_read: Can not read 1 bits, bits in cache 0, Byte * 8 40, size in bits 40
0:00:00.019532976  3198  0x9b74cf0 WARN       codecparsers_h264 gsth264parser.c:1819:gst_h264_parse_pps: failed to read SE
0:00:00.019537180  3198  0x9b74cf0 WARN       codecparsers_h264 gsth264parser.c:1826:gst_h264_parse_pps: error parsing "Picture parameter set"

The attached patch fixes the problem in rtph264pay, but maybe h264parse should ignore trailing zeroes too.
Comment 1 Tim-Philipp Müller 2017-08-24 15:05:28 UTC 
Created attachment 358352 [details] [review]
baseparse: fix taglist update spam

Does this help?
Comment 2 Tim-Philipp Müller 2017-08-24 15:12:47 UTC 
Comment on attachment 358352 [details] [review]
baseparse: fix taglist update spam

Wrong bug, sorry.
Comment 3 GStreamer system administrator 2018-11-03 14:53:22 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/122.