GNOME Bugzilla – Bug 732504
Hitori should store board size in gsettings
Last modified: 2014-07-07 12:55:37 UTC
When I open Hitori, the initial board size should be whatever it was when I last closed the game.
Created attachment 279968 [details] [review] Store board size in gsettings Remember the user's preferred board size
Review of attachment 279968 [details] [review]: ::: src/main.c @@ +179,3 @@ + size_str = g_settings_get_string (self->settings, "board-size"); + self->board_size = g_ascii_strtoull (size_str, NULL, 10); + g_settings_delay (self->settings); Why is this delayed?
I guess there's no need for it here. It's a habit to avoid extra writes when resizing a window where the window size is stored in gsettings. The advantage to not delaying the writes is that if hitori crashes, the changed board size won't be forgotten.
Created attachment 279993 [details] [review] Store board size in gsettings Remember the user's preferred board size
Review of attachment 279993 [details] [review]: Please mention in the commit message that this bumps the required GLib version to 2.32. ::: Makefile.am @@ +75,3 @@ +# GSettings +gsettings_SCHEMAS = data/org.gnome.hitori.gschema.xml Whoops, the patch seems to be missing this file. Sorry, I should have spotted this earlier.
Created attachment 280016 [details] [review] Store board size in gsettings Remember the user's preferred board size * Bump GLib dependency to 2.32, for g_settings_get_action() * Bump intltool dependency to 0.50.2, for automatic gsettings support
Review of attachment 280016 [details] [review]: ++
Attachment 280016 [details] pushed as e82fe40 - Store board size in gsettings