GNOME Bugzilla – Bug 732195
Add automated tests for gnome-clocks
Last modified: 2021-06-01 22:44:23 UTC
Created attachment 279159 [details] [review] Basic and World page related tests written in Behave Gnome-clocks should be covered with automated tests executable under GnomeContinuous.
Created attachment 279349 [details] [review] Basic and World page related tests written in Behave just a small enhancement
Review of attachment 279349 [details] [review]: Hi! sorry for the lack of feedback. I am not familiar at all with behave etc. Is it possible to move the tests in a "test" subdir? Apart from that, if your mentor reviews the tests and they are ok, feel free to push them.
Hi, I don't know if I understand correctly. You mean to rename the "tests" directory to "test"? Or create subdir of "tests" called "test"? I'm ok with options, so it depends on you. Thanks for the feedback anyway!
I think I just misread the patch and did not notice the files are already in a tests dir. So ignore that comment. However now I wonder how this works since you added the test to the Makefile.am of the parent directory.
Hi again, sorry for this delayed note. Well, those installed tests (executed under GnomeContinuous) are supposed to be installed only when the package is built with --enable-installed-tests, so this is the reason why I needed to add those three lines in Makefile.am in the top directory. The recipe for those tests is in m4/behave-installed-tests.m4 and few one-line statement is also in configure.ac, but all of those has the same reason - to install InstalledTests only when requested. I'm not a author of this structure, we used it widely for all applications so far, so I'm sorry if I wrote something wrong above. But in general, this should work well, and if not, I'm ready to fix it.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-clocks/-/issues/ Thank you for your understanding and your help.