After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732156 - h264parse: don't drop SEI buffering_period() messages
h264parse: don't drop SEI buffering_period() messages
Status: RESOLVED DUPLICATE of bug 732203
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 731831
 
 
Reported: 2014-06-24 12:37 UTC by Gwenole Beauchesne
Modified: 2014-07-01 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
h264parse: don't drop SEI buffering_period() messages (1.83 KB, patch)
2014-06-24 12:38 UTC, Gwenole Beauchesne 		rejected Details | Review
tests: h264parse: check SEI buffering_period() message is output (4.02 KB, patch)
2014-06-25 16:58 UTC, Gwenole Beauchesne 		rejected Details | Review

Description Gwenole Beauchesne 2014-06-24 12:37:46 UTC 
It is perfectly legal to have an SEI NAL unit with a buffering_period() message inserted between an SPS and PPS NAL unit. The former check that would drop anything before a PPS is seen is too restrictive.

The attached patch fixes several issues from bug #731974 when stream-format=byte-stream,alignment=au but the core issue remains and will be cured in another bug report.
Comment 1 Gwenole Beauchesne 2014-06-24 12:38:36 UTC 
Created attachment 279112 [details] [review]
h264parse: don't drop SEI buffering_period() messages
Comment 2 Gwenole Beauchesne 2014-06-25 16:58:36 UTC 
Created attachment 279235 [details] [review]
tests: h264parse: check SEI buffering_period() message is output

If an SEI NAL unit with a buffering_period() message is inserted between an SPS and PPS NAL unit, check that the output buffer still contain it. i.e. make sure that this SEI message is not dropped.
Comment 3 Gwenole Beauchesne 2014-06-25 17:04:44 UTC 
(In reply to comment #1)
> Created an attachment (id=279112) [details] [review]
> h264parse: don't drop SEI buffering_period() messages

This patch is obsoleted by the couple of patches from bug #732203. However, as mentioned there, I could tighten the check for very specific SEI message types, but I don't think the standard requires this restriction?
Comment 4 Sebastian Dröge (slomo) 2014-07-01 12:39:47 UTC 
So let's mark this as a duplicate of bug #732203 ?
Comment 5 Gwenole Beauchesne 2014-07-01 13:23:59 UTC 
OK with me. :)

*** This bug has been marked as a duplicate of bug 732203 ***