After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732070 - gobject-introspection-1.0.vapi: GI.BaseInfo.iterate_attributes wrong type
gobject-introspection-1.0.vapi: GI.BaseInfo.iterate_attributes wrong type
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GLib
0.24.x
Other Linux
: Normal minor
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-23 02:48 UTC by Adam Stark
Modified: 2016-09-17 08:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for the vapi file (665 bytes, patch)
2014-06-23 02:48 UTC, Adam Stark 		none Details | Review

Description Adam Stark 2014-06-23 02:48:47 UTC 
Created attachment 278970 [details] [review]
patch for the vapi file

'public bool iterate_attributes (GI.AttributeIter iterator, out unowned string name, out unowned string value);' should be 'public bool iterate_attributes (ref GI.AttributeIter iterator, out unowned string name, out unowned string value);'

IF there were any attributes (which I've never actually seen), a while loop over the iterator would rewrite the structure on every loop causing a non-terminating loop.
Comment 1 Luca Bruno 2014-06-24 08:08:24 UTC 
Thanks for the patch, however please note that the bindings are auto generated.
Comment 2 Adam Stark 2014-06-24 14:02:29 UTC 
Okay. I'll look into writing a .metadata file and/or editing the gobject-introspection doc tags on that project.