GNOME Bugzilla – Bug 732065
Install symbolic icons in the proper directory (Icons too large)
Last modified: 2014-10-16 08:09:45 UTC
Loading icons from a base directory (one that is directly added to the search path), instead of a subdirectory that is defined in the icon theme, is a legacy feature, and in particular it does not work very well for symbolic icons. After some recent gtk changes, these icons are now scaled to a giant size. This can be fixed by installing the icons into the subdirectory Adwaita/scalable/actions instead.
Created attachment 279341 [details] Screenshot - Geary with gtk+ from git master
Problem and solution are also described at https://mail.gnome.org/archives/gtk-devel-list/2014-June/msg00039.html
*** Bug 732947 has been marked as a duplicate of this bug. ***
The proposed fix works for me.
(In reply to comment #4) > The proposed fix works for me. You can to make a patch and to attach it to this bug?
I did it rather dirty by cp'ing icons to the suggested directory. I will have a look at the geary makefile to make a clean fix.
Created attachment 280273 [details] [review] proposed fix
Thanks, it works for me!
I want to make sure I understand before I commit this: doesn't this patch install these icons only for Adwaita? That is, if the user is using another theme, they will have these problems even with this patch?
Jim, I see the geary's custom icons also when I switch to elementary's icons, so it should work.
Review of attachment 280273 [details] [review]: Unfortunately, this patch does not work with GTK+ 3.10 or 3.12. The icons are not loaded, showing only the "missing image" icon in their place. GTK+ 3.10 is not a target for the next release, but GTK+ 3.12 is, so I can't take this patch as-is. There's two possibilities: (a) Update the Geary code to properly search for the icons in the new location, potentially by adding a search path to the icon loader. I have no idea if this is feasible, I'm just throwing it out there. (b) The CMakeLists.txt file use conditionals to pick the proper install path.
*** Bug 733474 has been marked as a duplicate of this bug. ***
*** Bug 737024 has been marked as a duplicate of this bug. ***
*** Bug 737260 has been marked as a duplicate of this bug. ***
Note that Matthias Clasen posted a patch with a different work-around in bug #737260.
*** Bug 737309 has been marked as a duplicate of this bug. ***
Pushed to master, commit f1fc86 I'll probably include this in an 0.8.1.
I build it from repo for F21 and icons are back to normal. I found only one that seems to be missed out (see attachment). RPM: http://copr-be.cloud.fedoraproject.org/results/comzeradd/geary-git/fedora-21-x86_64/geary-140926-1.fc21/geary-140926-1.fc21.x86_64.rpm
Created attachment 287144 [details] Screenshot of missed "X" icon
*** Bug 737430 has been marked as a duplicate of this bug. ***
Ok, we need to fix that "X" too.
This may not be the place to discuss it, but that X is different from the one in the find bar, for example. They used to be the same. Was that change intentional? We may also need to check the X in the misleading link warning.
I don't recall if that was intentional or not. I would have to look through git blame.
*** Bug 737537 has been marked as a duplicate of this bug. ***
*** Bug 737664 has been marked as a duplicate of this bug. ***
*** Bug 737542 has been marked as a duplicate of this bug. ***
Remaining icons issues fixed in commit d7e813. See bug #737861 for proper 3.14 fix to install icons in theme directory.
*** Bug 738510 has been marked as a duplicate of this bug. ***