After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731993 - Default hotkeys require number pad
Default hotkeys require number pad
Status: RESOLVED FIXED
Product: gnome-robots
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal minor
: ---
Assigned To: Michael Catanzaro
gnome-robots-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-20 23:51 UTC by Michael Catanzaro
Modified: 2014-06-22 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use more reasonable hotkeys (3.30 KB, patch)
2014-06-21 13:34 UTC, Michael Catanzaro
none Details | Review
Update user help for new hotkeys (2.39 KB, patch)
2014-06-21 14:17 UTC, Michael Catanzaro
none Details | Review
Use more reasonable hotkeys (6.57 KB, patch)
2014-06-21 19:12 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-06-20 23:51:19 UTC
All hotkeys (Preferences -> Keyboard) seem to be broken, as of at least 3.10.  I guess we're going to have to go back in time to see how many years it's been since these have worked....
Comment 1 Michael Catanzaro 2014-06-21 01:13:50 UTC
OK, they actually work fine, it's just that the default keys require a number pad for them to work... I guess Robots was written in a time before laptops....

I hesitate to change this, since the default wouldn't make much sense without the number pad. Guess these need to be rethought.
Comment 2 Mario Wenzel 2014-06-21 08:01:29 UTC
I guess we would want to add nethack-controls. They are suitable and quite well known. I think this would be the best way to map the 8 directions onto the keyboard.

"The hjkl keys move your character to the adjacent square west, south, north, or east. The yubn keys move your character diagonally."
source: http://strategywiki.org/wiki/NetHack/Controls#yuhjklbn

This way of doing it precedes Numpads on keyboards by quite a few years, I guess.
Comment 3 Michael Catanzaro 2014-06-21 13:34:00 UTC
Created attachment 278892 [details] [review]
Use more reasonable hotkeys

All of the previous hotkeys assume the existance of a number pad. Do
people have number pads anymore?
Comment 4 Michael Catanzaro 2014-06-21 14:00:18 UTC
Any suggestions for the non-directional hotkeys (teleport safely, teleport randomly, wait one turn, wait forever)? I kept them at their original values after switching to non-number pad keys, but these no longer make any sense at all. Teleport safely is =, teleport randomly is 8, etc.

Maybe , and . would make sense for wait one turn and wait forever? Maybe r and s for random and safe teleport?
Comment 5 Michael Catanzaro 2014-06-21 14:17:44 UTC
Created attachment 278893 [details] [review]
Update user help for new hotkeys
Comment 6 Mario Wenzel 2014-06-21 18:29:56 UTC
Wait or skip turn is traditionally space. I think rogue's or nethacks controls, seeing that we have the same view as those games, we could take a hint from there.
Comment 7 Michael Catanzaro 2014-06-21 19:12:09 UTC
Let's use space to skip one turn, and remove hotkeys from the other three -- mnemonics should be enough, and it would really suck to accidentally teleport because you pressed the wrong button.

The following fix has been pushed:
66a3421 Use more reasonable hotkeys
Comment 8 Michael Catanzaro 2014-06-21 19:12:16 UTC
Created attachment 278904 [details] [review]
Use more reasonable hotkeys

All of the previous hotkeys assume the existance of a number pad. Do
people have number pads anymore?
Comment 9 Mario Wenzel 2014-06-22 08:36:10 UTC
Can we have both numpad and rogue-inputs? Or can we sense that in any way or switch between setups?
Comment 10 Michael Catanzaro 2014-06-22 13:30:17 UTC
Well our hotkey manager only allows one hotkey per command. I guess the easiest way to get around this would be to add a hidden set of additional default hotkeys. This is what GNOME does to make Alt+Tab work even though the hotkey manager says Super+Tab.

But probably if you want to use a number pad, you'd just have to set the hotkeys yourself. This seems acceptable to me: the new hotkeys are totally useless unless you have a qwerty keyboard, for instance, so many users will have to do this anyway.