After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731976 - Use a gdbus-codegen-ed GDBusInterfaceSkeleton and GApplication
Use a gdbus-codegen-ed GDBusInterfaceSkeleton and GApplication
Status: RESOLVED FIXED
Product: gnome-online-miners
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Miners maintainer(s)
GNOME Online Miners maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-20 17:09 UTC by Debarshi Ray
Modified: 2014-06-24 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use a gdbus-codegen-ed GDBusInterfaceSkeleton and GApplication (20.49 KB, patch)
2014-06-20 17:15 UTC, Debarshi Ray
none Details | Review
Remove unused MINER_OBJECT_PATH (2.60 KB, patch)
2014-06-20 17:24 UTC, Debarshi Ray
committed Details | Review
Use a gdbus-codegen-ed GDBusInterfaceSkeleton and GApplication (20.54 KB, patch)
2014-06-24 15:36 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2014-06-20 17:09:34 UTC
... instead of manually handling method calls, properties, automatic timeouts, etc..

While going through the patch to add an extra 'as' parameter to RefreshDB (bug 728878), I realized that we don't need to deal with so much detail about acquiring the bus, registering objects on it, unwrapping the parameters from the GVariant, etc.. This is only going to get more complicated as the API evolves (eg., if we add a signal in the future).

I think that using a gdbus-codegen-ed GDBusInterfaceSkeleton and GApplication makes things easier by reducing some of these details and generating the corresponding C API from the XML for us. If not anything else, it makes it more consistent with all the code out there that is already using GApplication and gdbus-codegen.
Comment 1 Debarshi Ray 2014-06-20 17:15:59 UTC
Created attachment 278850 [details] [review]
Use a gdbus-codegen-ed GDBusInterfaceSkeleton and GApplication
Comment 2 Debarshi Ray 2014-06-20 17:24:14 UTC
Created attachment 278851 [details] [review]
Remove unused MINER_OBJECT_PATH
Comment 3 Debarshi Ray 2014-06-24 15:27:16 UTC
I am pushing these now, so that I can rebase the patches in bug 728878 on top of these.
Comment 4 Debarshi Ray 2014-06-24 15:36:50 UTC
Created attachment 279125 [details] [review]
Use a gdbus-codegen-ed GDBusInterfaceSkeleton and GApplication

Fix make distcheck.