Bug 731913 – contacts-accounts-list: Don’t add a missing local store to the UI

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 731913 - contacts-accounts-list: Don’t add a missing local store to the UI


Summary:	contacts-accounts-list: Don’t add a missing local store to the UI


Status:	RESOLVED FIXED

Product:	gnome-contacts
Classification:	Core
Component:	general
Version:	3.10.x
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Contacts maintainer(s)
QA Contact:	GNOME Contacts maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-06-19 15:00 UTC by Philip Withnall
Modified:	2014-06-19 17:21 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
contacts-accounts-list: Don’t add a missing local store to the UI (2.39 KB, patch) 2014-06-19 15:00 UTC, Philip Withnall	committed	Details \| Review

Description Philip Withnall 2014-06-19 15:00:32 UTC

This fixes a crash reported on the mailing list:

https://mail.gnome.org/archives/gnome-contacts-list/2014-June/msg00009.html


(gnome-contacts:9413): eds-CRITICAL **: edsf_persona_store_get_source: assertion 'self != NULL' failed

Program received signal SIGTRAP, Trace/breakpoint trap.
0x00007fffe97604ca in g_logv () from /usr/local/lib/libglib-2.0.so.0
(gdb) thread apply all backtrace

+ Trace 233712

Thread 1 (LWP 9413)

#0 g_logv
from /usr/local/lib/libglib-2.0.so.0
#1 g_log
from /usr/local/lib/libglib-2.0.so.0
#2 edsf_persona_store_get_source.part.30
at edsf-persona-store.c line 11531
#3 edsf_persona_store_get_source
at edsf-persona-store.c line 11528
#4 __lambda132_.isra.1
at contacts-setup-window.c line 253
#5 ___lambda132__gtk_button_clicked.25877
at contacts-setup-window.c line 261
#6 g_signal_emit_valist
from /usr/local/lib/libgobject-2.0.so.0
#7 g_signal_emit
from /usr/local/lib/libgobject-2.0.so.0
#8 ??
from /usr/local/lib/libgtk-3.so.0
#9 ??
from /usr/local/lib/libgtk-3.so.0
#10 g_closure_invoke
from /usr/local/lib/libgobject-2.0.so.0
#11 ??
from /usr/local/lib/libgobject-2.0.so.0
#12 g_signal_emit_valist
from /usr/local/lib/libgobject-2.0.so.0
#13 g_signal_emit
from /usr/local/lib/libgobject-2.0.so.0
#14 ??
from /usr/local/lib/libgtk-3.so.0
#15 ??
from /usr/local/lib/libgtk-3.so.0
#16 g_signal_emit_valist
from /usr/local/lib/libgobject-2.0.so.0
#17 g_signal_emit
from /usr/local/lib/libgobject-2.0.so.0
#18 ??
from /usr/local/lib/libgtk-3.so.0
#19 ??
from /usr/local/lib/libgtk-3.so.0
#20 gtk_main_do_event
from /usr/local/lib/libgtk-3.so.0
#21 ??
from /usr/local/lib/libgdk-3.so.0
#22 g_main_context_dispatch
from /usr/local/lib/libglib-2.0.so.0
#23 ??
from /usr/local/lib/libglib-2.0.so.0
#24 g_main_context_iteration
from /usr/local/lib/libglib-2.0.so.0
#25 g_application_run
from /usr/local/lib/libgio-2.0.so.0
#26 _vala_main
at main.c line 72
#27 __libc_start_main
from /lib/libc.so.6
#28 _start
at ../sysdeps/x86_64/start.S line 123

Thread 1 (LWP 9413)

#0 g_logv
from /usr/local/lib/libglib-2.0.so.0
#1 g_log
from /usr/local/lib/libglib-2.0.so.0
#2 contacts_setup_window_select_source
at contacts-setup-window.c line 170
#3 __lambda132_.isra.1
at contacts-setup-window.c line 255
#4 ___lambda132__gtk_button_clicked.25877
at contacts-setup-window.c line 261
#5 g_signal_emit_valist
from /usr/local/lib/libgobject-2.0.so.0
#6 g_signal_emit
from /usr/local/lib/libgobject-2.0.so.0
#7 ??
from /usr/local/lib/libgtk-3.so.0
#8 ??
from /usr/local/lib/libgtk-3.so.0
#9 g_closure_invoke
from /usr/local/lib/libgobject-2.0.so.0
#10 ??
from /usr/local/lib/libgobject-2.0.so.0
#11 g_signal_emit_valist
from /usr/local/lib/libgobject-2.0.so.0
#12 g_signal_emit
from /usr/local/lib/libgobject-2.0.so.0
#13 ??
from /usr/local/lib/libgtk-3.so.0
#14 ??
from /usr/local/lib/libgtk-3.so.0
#15 g_signal_emit_valist
from /usr/local/lib/libgobject-2.0.so.0
#16 g_signal_emit
from /usr/local/lib/libgobject-2.0.so.0
#17 ??
from /usr/local/lib/libgtk-3.so.0
#18 ??
from /usr/local/lib/libgtk-3.so.0
#19 gtk_main_do_event
from /usr/local/lib/libgtk-3.so.0
#20 ??
from /usr/local/lib/libgdk-3.so.0
#21 g_main_context_dispatch
from /usr/local/lib/libglib-2.0.so.0
#22 ??
from /usr/local/lib/libglib-2.0.so.0
#23 g_main_context_iteration
from /usr/local/lib/libglib-2.0.so.0
#24 g_application_run
from /usr/local/lib/libgio-2.0.so.0
#25 _vala_main
at main.c line 72
#26 __libc_start_main
from /lib/libc.so.6
#27 _start
at ../sysdeps/x86_64/start.S line 123

Comment 1 Philip Withnall 2014-06-19 15:00:56 UTC

Created attachment 278769 [details] [review]
contacts-accounts-list: Don’t add a missing local store to the UI

If the local store can’t be found, don’t add it to the UI.

Comment 2 Erick Perez Castellanos 2014-06-19 16:36:53 UTC

Looks good to me. Commit now

Comment 3 Philip Withnall 2014-06-19 17:21:44 UTC

Comment on attachment 278769 [details] [review]
contacts-accounts-list: Don’t add a missing local store to the UI

commit 4737f02f3d6c7d6364e92f6d9a938e50d5609bf7
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Thu Jun 19 15:56:43 2014 +0100

    contacts-accounts-list: Don’t add a missing local store to the UI
    
    If the local store can’t be found, don’t add it to the UI.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731913

 src/contacts-accounts-list.vala | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)