After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731582 - Please use AC_PATH_TOOL to improve cross-compile & multilib support
Please use AC_PATH_TOOL to improve cross-compile & multilib support
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-06-12 15:30 UTC by Michał Górny
Modified: 2014-07-25 19:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk+3 AC_PATH_TOOL patch (1.05 KB, patch)
2014-06-12 15:30 UTC, Michał Górny 		committed Details | Review
gtk+2 AC_PATH_TOOL patch (1.07 KB, patch)
2014-06-12 15:31 UTC, Michał Górny 		committed Details | Review

Description Michał Górny 2014-06-12 15:30:44 UTC 
Created attachment 278352 [details] [review]
gtk+3 AC_PATH_TOOL patch

Currently, GTK+ is using AC_PATH_PROG to find a few build tools such as 'cups-config'. This doesn't handle cases when there are multiple versions of such a tool installed such as when cross-compilation is done or multilib build is performed in Gentoo.

Please switch the relevant macros from AC_PATH_PROG to AC_PATH_TOOL that prefers ${CHOST}-prefixed tools over non-prefixed tools. Potential cases for switch are:

- AC_PATH_PROG(NM, nm, nm) -> i suspect different arch may need different version of nm,

- AC_PATH_PROG(CUPS_CONFIG, cups-config, no) -> cups-config may contain arch/abi-specific paths.

Possibly more tools may need AC_PATH_TOOL.

I'm attaching patch for the two against gtk+3 master.
Comment 1 Michał Górny 2014-06-12 15:31:37 UTC 
Created attachment 278353 [details] [review]
gtk+2 AC_PATH_TOOL patch

And a similar patch against gtk-2-24 branch.
Comment 2 Andrey Gursky 2014-06-30 17:23:08 UTC 
This bug has been first mentioned in https://bugzilla.gnome.org/show_bug.cgi?id=671515. Please link it.

Thanks,
Andrey