After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731346 - pull: Emit a better error if the remote isn't found
pull: Emit a better error if the remote isn't found
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-06 20:20 UTC by Colin Walters
Modified: 2014-06-19 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pull: Emit a better error if the remote isn't found (1.35 KB, patch)
2014-06-06 20:20 UTC, Colin Walters
none Details | Review
pull: Emit a better error if the remote isn't found (1.36 KB, patch)
2014-06-19 08:40 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2014-06-06 20:20:37 UTC
The generic GKeyFile error isn't quite informative enough here.

I hit this with the new compose process where we don't automatically
inject a configured remote into the generated disk images; we expect
people to add them.
Comment 1 Colin Walters 2014-06-06 20:20:39 UTC
Created attachment 278053 [details] [review]
pull: Emit a better error if the remote isn't found
Comment 2 Colin Walters 2014-06-19 08:40:26 UTC
Created attachment 278740 [details] [review]
pull: Emit a better error if the remote isn't found

The generic GKeyFile error isn't quite informative enough here.

I hit this with the new compose process where we don't automatically
inject a configured remote into the generated disk images; we expect
people to add them.
Comment 3 Andy Grimm 2014-06-19 15:19:20 UTC
Review of attachment 278740 [details] [review]:

This looks good to me.  You could also mention the procedure for adding a remote, but I don't know how verbose you want to be here.
Comment 4 Colin Walters 2014-06-19 16:05:12 UTC
I've strugged a bit with "single sentence" error messages versus
"friendly" errors on the command line.  I think probably if we have
more text here though it should go in the docs.

Attachment 278740 [details] pushed as bb043b3 - pull: Emit a better error if the remote isn't found