After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731335 - gtype: guard uses of new fundamental type check
gtype: guard uses of new fundamental type check
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-06-06 14:49 UTC by Allison Karlitskaya (desrt)
Modified: 2014-06-06 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtype: guard uses of new fundamental type check (1.96 KB, patch)
2014-06-06 14:49 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-06-06 14:49:28 UTC 
g_type_is_fundamentally_a (see bug 730984) is a new API/ABI and is
marked with a version macro.  We should therefore avoid its
unconditional use from G_IS_OBJECT() and G_IS_PARAM_SPEC() which are
APIs that have been around for a long time.

This prevents deprecation warnings from being emitted when these
functions are used with an older GLIB_VERSION_MAX_ALLOWED and also
prevents linking to the new ABI in that case (so that it's possible to
use the resulting binary with an older version of GLib).
Comment 1 Allison Karlitskaya (desrt) 2014-06-06 14:49:29 UTC 
Created attachment 278037 [details] [review]
gtype: guard uses of new fundamental type check
Comment 2 Emmanuele Bassi (:ebassi) 2014-06-06 14:52:53 UTC 
Review of attachment 278037 [details] [review]:

looks good to me.
Comment 3 Allison Karlitskaya (desrt) 2014-06-06 14:59:59 UTC 
Attachment 278037 [details] pushed as d558e87 - gtype: guard uses of new fundamental type check