GNOME Bugzilla – Bug 731316
Some fixes to the headerbar
Last modified: 2014-06-13 18:59:25 UTC
See the patches (merge them if you want).
Created attachment 277992 [details] [review] Show close button in the headerbar when not build for unity
Created attachment 277993 [details] [review] Fix the size of the window menu
Created attachment 277994 [details] [review] Fix the order of the buttons in the end of the headerbar Since we target for GTK+ 3.12, we needs to pack the buttons by the new order, which changes in GTK+ 3.12: https://git.gnome.org/browse/gtk+/tree/README.in#n85
For the first patch, I removed the close button from the header bar because the window menu now has Quit (that is, to conserve space on the headerbar). Is the general consensus out there that we should have a close button and a Quit menu item, or one or the other? I've applied the second patch, thanks. Pushed to master, commit 07e1da Regarding the third patch, California is still built against 3.10, so I can't take this as-is. We need to only use it for 3.12 and onward. Vala doesn't offer a way to do this, we'll need to make a flag in automake that is set when GTK+ version >= 3.12.
Mistake, the commit is commit 4984f5
(In reply to comment #4) > For the first patch, I removed the close button from the header bar because the > window menu now has Quit (that is, to conserve space on the headerbar). Is the > general consensus out there that we should have a close button and a Quit menu > item, or one or the other? You needs to remove the Quit item from the gear menu because we have it in the app menu. Also, you always want a close button in the main window because this is part of the GNOME 3 HIG. Infact (from GTK+ 3.12) it not only a close button, it can to be also minimize, maximize and appmenu buttons depend on the “gtk-decoration-layout” property of the default GtkSettings (and can be set in dconf/gsettings somewhere): https://developer.gnome.org/gtk3/3.12/GtkSettings.html#GtkSettings--gtk-decoration-layout > > I've applied the second patch, thanks. Pushed to master, commit 07e1da > > Regarding the third patch, California is still built against 3.10, so I can't > take this as-is. We need to only use it for 3.12 and onward. Vala doesn't > offer a way to do this, we'll need to make a flag in automake that is set when > GTK+ version >= 3.12. Hmm, ok.
I applied your first patch and removed the Quit item: commit 7874c1 The 3.12 button ordering patch is committed as well but with some automake checking for conditional compilation: commit 1e6ade