After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731314 - On game over, prompt the user to play again
On game over, prompt the user to play again
Status: RESOLVED FIXED
Product: hitori
Classification: Applications
Component: General
0.4.x
Other All
: Normal normal
: ---
Assigned To: hitori-maint
hitori-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-06 04:53 UTC by Michael Catanzaro
Modified: 2014-06-17 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
On game over, prompt the user to play again (1.96 KB, patch)
2014-06-06 04:53 UTC, Michael Catanzaro
none Details | Review
On game over, prompt the user to play again (1.95 KB, patch)
2014-06-06 15:54 UTC, Michael Catanzaro
accepted-commit_now Details | Review
On game over, prompt the user to play again (1.95 KB, patch)
2014-06-17 14:03 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-06-06 04:53:46 UTC
Instead of just telling the user his time and giving him an OK button, let's allow him to choose to either quit or start a new game. Otherwise the only way to start a new game would be to use the new game action in the app menu (awkward -- new game is too important to hide up there) or select the current board size again (currently the easiest approach).
Comment 1 Michael Catanzaro 2014-06-06 04:53:48 UTC
Created attachment 277990 [details] [review]
On game over, prompt the user to play again

This allows us to simplify the UI by obviating the need to move the new
game action from the app menu into the window. It's also simply more
useful than an OK button.

The user can instead choose to quit the app from this dialog. What a
timesaver!
Comment 2 Michael Catanzaro 2014-06-06 15:54:13 UTC
Created attachment 278039 [details] [review]
On game over, prompt the user to play again

This allows us to simplify the UI by obviating the need to move the new
game action from the app menu into the window. It's also simply more
useful than an OK button.

The user can instead choose to quit the app from this dialog. What a
timesaver!
Comment 3 Philip Withnall 2014-06-11 08:29:40 UTC
Review of attachment 278039 [details] [review]:

One minor nit, otherwise the patch looks good, thanks! Please commit with this change.

::: src/rules.c
@@ +271,3 @@
+		gtk_dialog_add_buttons (GTK_DIALOG (dialog),
+					_("_Quit"), GTK_RESPONSE_REJECT,
+					_("Play _Again"), GTK_RESPONSE_ACCEPT,

I think the mnemonics for 'Play Again' here and 'Keep Playing' in bug #731337 should be made consistent (i.e. both should be 'P').

So this should be '_Play Again'.
Comment 4 Michael Catanzaro 2014-06-17 14:03:26 UTC
Created attachment 278604 [details] [review]
On game over, prompt the user to play again

This allows us to simplify the UI by obviating the need to move the new
game action from the app menu into the window. It's also simply more
useful than an OK button.

The user can instead choose to quit the app from this dialog. What a
timesaver!
Comment 5 Michael Catanzaro 2014-06-17 14:03:37 UTC
Attachment 278604 [details] pushed as d2bf067 - On game over, prompt the user to play again