After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731047 - ximagesink, xvimagesink: configure checks pull in libSM and libICE even though they are not used
ximagesink, xvimagesink: configure checks pull in libSM and libICE even thoug...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.2.4
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-31 13:54 UTC by Pacho Ramos
Modified: 2014-11-27 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Pacho Ramos 2014-05-31 13:54:36 UTC 
The AC_PATH_XTRA macro unnecessarily pulls in libSM and libICE even though they are not actually used. We run this downstream:
        # replacing AC_PATH_XTRA with PKG_CONFIG calls.
        sed -i -e 's:X_PRE_LIBS -lSM -lICE:X_PRE_LIBS:' "${S}"/configure
Comment 1 Tim-Philipp Müller 2014-08-10 16:34:20 UTC 
This should hopefully fix it (not sure whether that still works on the 1985 release of AIX, but only one way to find out I suppose ;)):

 commit f7d6087d53944a56906ad5240bf9abe2f0146c4f
 Author: Tim-Philipp Müller <tim@centricular.com>
 Date:   Sun Aug 10 17:30:18 2014 +0100

    configure: use pkg-config to detect x11 and xv libs
    
    AC_PATH_XTRA macro unnecessarily pulls in libSM and libICE.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731047
Comment 2 Sebastian Dröge (slomo) 2014-08-11 07:47:44 UTC 
This breaks the build on the buildbots as it makes X11 mandatory now
Comment 3 Sebastian Dröge (slomo) 2014-08-11 10:48:30 UTC 
Fixed now

commit eefa8c366e31b4d25da80dc6238ead0df89367d7
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Mon Aug 11 09:26:17 2014 +0100

    configure: fix x11 checks to be non-fatal again
    
    Must pass an action-if-not-found argument to
    PKG_CHECK_MODULES or it will error out when
    it can't find the module requested. Also fix
    AC_CHECK_LIB usage, extra libs argument was
    in the wrong place.
Comment 4 Jan Schmidt 2014-08-26 04:17:11 UTC 
This breaks the cerbero Android cross compiling, which for some reason still has /usr/lib64/pkgconfig in the PKG_CONFIG_PATH and therefore detects Xv. Just a note, this commit is obviously correct - it's cerbero that's broken.
Comment 5 Edward Hervey 2014-11-27 10:12:43 UTC 
And it breaks the debian/fedora cerbero builds because ... it's not looking in the system paths for those.