GNOME Bugzilla – Bug 731035
Unclean shutdown in sftp backend
Last modified: 2014-06-05 20:26:59 UTC
If the remote sftp server dies (i.e. using pkill sftp-server), the sftp backend correctly detects it and calls force_unmount but then proceeds with reading from the connection (since force_unmount doesn't quit immediately). This results in output like: """ ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) """ before the sftp backend finally exits.
Created attachment 277608 [details] [review] sftp: Quit more cleanly on remote shutdown Don't issue any operations after g_vfs_backend_force_unmount() is called. This prevents output like: """ forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) forced_unregister_mount_callback ** (process:3348): WARNING **: Error unregistering mount: Mountpoint not registered (g-io-error-quark, 16) """ when the remote sftp-server process quits unexpectedly.
Review of attachment 277608 [details] [review]: Looks good, but the commit message could be shorter...
(In reply to comment #2) > Review of attachment 277608 [details] [review]: > > Looks good, but the commit message could be shorter... That's a good point :-) Pushed to master as e103eba, with a shorter commit message. Thanks for the review!