After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731003 - build: use typelib and gir directories from gi's pkgconfig info
build: use typelib and gir directories from gi's pkgconfig info
Status: RESOLVED OBSOLETE
Product: json-glib
Classification: Core
Component: Core
git master
Other All
: Normal normal
: ---
Assigned To: json-glib-maint
json-glib-maint
Depends on: 723862
Blocks:
 
 
Reported: 2014-05-30 15:34 UTC by Andoni Morales
Modified: 2017-09-05 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use typelib and gir directories from gi's pkgconfig info (1006 bytes, patch)
2014-05-30 15:34 UTC, Andoni Morales
rejected Details | Review
0001-build-use-typelib-and-gir-dirs-from-gi-s-pkgconfig-i.patch (1.01 KB, patch)
2014-05-30 16:54 UTC, Andoni Morales
none Details | Review

Description Andoni Morales 2014-05-30 15:34:34 UTC
Created attachment 277567 [details] [review]
use typelib and gir directories from gi's pkgconfig info

use typelib and gir directories from gi's pkgconfig info
Comment 1 Emmanuele Bassi (:ebassi) 2014-05-30 15:56:33 UTC
no, this will break tools like distcheck and package tools because it will discard things like DESTDIR and custom prefixes.

you'll have to fix gobject-introspection first to provide the correct targets for this.
Comment 2 Andoni Morales 2014-05-30 16:02:29 UTC
This patch is related to https://bugzilla.gnome.org/show_bug.cgi?id=723862 where I need to set a subdirectory for each architecture in universal builds.

I have added confiurables GIR_SUFFIX and TYPELIB_SUFFIX, can we use them instead of gir-1.0 and girepository-1.0, eg:

typelibsdir = $(libdir)/$(INTROSPECTION_TYPELIB_SUFFIX)
Comment 3 Andoni Morales 2014-05-30 16:54:35 UTC
Created attachment 277574 [details] [review]
0001-build-use-typelib-and-gir-dirs-from-gi-s-pkgconfig-i.patch

Update patch with new changes in #723862
Comment 4 Emmanuele Bassi (:ebassi) 2017-09-05 10:41:29 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/json-glib/issues/14.