GNOME Bugzilla – Bug 730964
Notifications don't show
Last modified: 2014-05-31 18:37:56 UTC
When trying "/help" I expect a notification to pop up somewhere, but it doesnt happen, same applies for all commands that should generate a feedback label/grid/somemthing else. Debugging info: I tried debugging this a bit, I noticed that notifications are controlled by the classes defined in appNotification.js, the base class in this file has a Gtk.Revealer named widget that holds the notification but I can't seem to find where it is attached to the main UI, the widget reports having no parent at all. To verify this I added a log statement to appNotifications.js/NotificationQueue/addNotification which does get hit, but still reports that this.widget has no parent at all.
Which version is this about?
I see this bug already a long time. It was with polari stable (3.12) and gtk+ 3.12, and now it with polari from git master and gtk+ from git master.
(In reply to comment #0) > When trying "/help" I expect a notification to pop up somewhere, but it doesnt > happen, same applies for all commands that should generate a feedback > label/grid/somemthing else. > > Debugging info: > I tried debugging this a bit, I noticed that notifications are controlled by > the classes defined in appNotification.js, the base class in this file has a > Gtk.Revealer named widget that holds the notification but I can't seem to find > where it is attached to the main UI, the widget reports having no parent at > all. Ugh, yes - https://git.gnome.org/browse/polari/commit?id=4934cf62423cbc0ef moved code around, and adding the two in-app notification queues fell through the cracks. Now, adding the two lines back in the new place is trivial, but the overall widget hierarchy has changed in the meantime, so the bottom notifications now pop up over the entry rather than emerging from it. I'll take a closer look later today ... (In reply to comment #2) > I see this bug already a long time. ... which obviously does not help with fixing it when you keep it to yourself ;-) Seriously, don't hesitate to report any issues you find - having to close a couple of dupes is way better than missing bugs.
Created attachment 277549 [details] [review] Fix in-app notifications Since the reshuffling in commit 4934cf62423cbc, the two in-app notification queues were no longer added to the toplevel widget hierarchy. Whooops, fix that!
Created attachment 277550 [details] [review] mainWindow: Offset bottom notifications to appear above entry area Since the hierarchy was simplified to use a single stack for both chat log and entries, the overlay which holds in-app notifications now extends to the bottom of the window. However we don't want notifications to cover the entry area, so offset them appropriately to restore the previous behavior.
Attachment 277549 [details] pushed as 7cbf6c6 - Fix in-app notifications Attachment 277550 [details] pushed as 931efbf - mainWindow: Offset bottom notifications to appear above entry area
(In reply to comment #3) > (In reply to comment #2) > > I see this bug already a long time. > > ... which obviously does not help with fixing it when you keep it to yourself > ;-) > Seriously, don't hesitate to report any issues you find - having to close a > couple of dupes is way better than missing bugs. I just a bit lazy ;-) Thanks for fixed this. I just see now some strings in the in-app-notif in English. I added some files to the POTFILES.in and translated them, but I still see some English strings when I type '/help bla'.
(In reply to comment #7) > I just see now some strings in the in-app-notif in English. > I added some files to the POTFILES.in and translated them, > but I still see some English strings when I type '/help bla'. Fixed that as well now.
(In reply to comment #8) > (In reply to comment #7) > > I just see now some strings in the in-app-notif in English. > > I added some files to the POTFILES.in and translated them, > > but I still see some English strings when I type '/help bla'. > > Fixed that as well now. Thanks!