After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730936 - make dropped tab active
make dropped tab active
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
3.13.x
Other Linux
: Normal minor
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-29 12:09 UTC by Christian Persch
Modified: 2014-06-20 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (434 bytes, patch)
2014-05-30 13:39 UTC, Egmont Koblinger 		none Details | Review
Fix v2 (428 bytes, patch)
2014-06-19 17:18 UTC, Egmont Koblinger 		none Details | Review
Fix v3 (456 bytes, patch)
2014-06-19 17:34 UTC, Egmont Koblinger 		committed Details | Review

Description Christian Persch 2014-05-29 12:09:11 UTC 
When dropping the tab in the tab bar, it's made active, but when dropping it in the terminal, it's not made active. The drop behaviour should be made identical in both places.
Comment 1 Egmont Koblinger 2014-05-30 13:39:22 UTC 
Created attachment 277546 [details] [review]
Fix

Am I addressing it at the right place?
Comment 2 Christian Persch 2014-05-30 14:02:09 UTC 
No, terminal_window_move_screen is the right place, IMO.
Comment 3 Egmont Koblinger 2014-06-19 17:18:38 UTC 
Created attachment 278786 [details] [review]
Fix v2

Like this?

I don't understand the MdiContainer/ScreenContainer business yet, so I really can't tell what's the proper design.
Comment 4 Christian Persch 2014-06-19 17:32:07 UTC 
Yes, but move it before the unref please.
Comment 5 Egmont Koblinger 2014-06-19 17:34:16 UTC 
Created attachment 278787 [details] [review]
Fix v3

done