After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730928 - glcolorscale: avoid using extra FBO pass
glcolorscale: avoid using extra FBO pass
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 732178
Blocks:
 
 
Reported: 2014-05-29 10:13 UTC by Julien Isorce
Modified: 2014-07-02 04:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Julien Isorce 2014-05-29 10:13:23 UTC
1- should support GstBaseTransformClass->passthrough_on_same_caps

Indeed if the caps are exactly the same, there is nothing to do (i.e. no need upload->download)

2- Currently "videotestsrc ! glcolorscale ! "GL" ! fakesink" uses 2 FBO, one
for the upload and one that just does the identity. The later should be
avoided.
Comment 1 Matthew Waters (ystreet00) 2014-07-02 04:25:08 UTC
This should be fixed by

https://bugzilla.gnome.org/show_bug.cgi?id=732178

and 

commit 720405b56188773a68ac521b491c21a4eac61f05
Author: Matthew Waters <ystreet00@gmail.com>
Date:   Wed Jun 25 22:05:37 2014 +1000

    glfilter: pass through the allocation query when in passthrough mode
    
    Otherwise two GL elements on either side will fail to use the same
    GL context.